Resolve comments

Shopify · Jul 19, 2021 · d688e85 · d688e85
1 parent c731a54
commit d688e85
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/react/src/host/RemoteText.tsx b/packages/react/src/host/RemoteText.tsx
@@ -3,8 +3,8 @@ import {memo} from 'react';
 import type {RemoteTextProps} from './types';
 import {useAttached} from './hooks';
 
-export function renderText({text, receiver, ...extraProps}: RemoteTextProps) {
-  return <RemoteText {...extraProps} text={text} receiver={receiver} />;
+export function renderText({text, receiver, key}: RemoteTextProps) {
+  return <RemoteText key={key} text={text} receiver={receiver} />;
 }
 
 export const RemoteText = memo(({text, receiver}: RemoteTextProps) => {

diff --git a/packages/react/src/host/controller.tsx b/packages/react/src/host/controller.tsx
@@ -1,4 +1,4 @@
-import type {ComponentType, ReactElement} from 'react';
+import type {ComponentType, ReactNode} from 'react';
 import type {
   Controller,
   RemoteComponentProps,
@@ -19,8 +19,8 @@ interface RendererFactory {
   renderComponent(
     props: RemoteComponentProps,
     options: RenderComponentOptions,
-  ): ReactElement;
-  renderText(props: RemoteTextProps, options: RenderTextOptions): ReactElement;
+  ): ReactNode;
+  renderText(props: RemoteTextProps, options: RenderTextOptions): ReactNode;
 }
 
 const renderComponentOptions = {renderDefault: defaultRenderComponent};
@@ -38,7 +38,7 @@ export function createController(
     ? (component) => externalRenderComponent(component, renderComponentOptions)
     : defaultRenderComponent;
   const renderText: Renderer['renderText'] = externalRenderText
-    ? (component) => externalRenderText(component, renderTextOptions)
+    ? (text) => externalRenderText(text, renderTextOptions)
     : defaultRenderText;
 
   return {

diff --git a/packages/react/src/host/types.ts b/packages/react/src/host/types.ts
@@ -1,4 +1,4 @@
-import type {ComponentType, ReactElement} from 'react';
+import type {ComponentType, ReactNode} from 'react';
 import type {
   RemoteReceiver,
   RemoteReceiverAttachableComponent,
@@ -32,8 +32,8 @@ export interface Controller {
 }
 
 export interface Renderer {
-  renderComponent(props: RemoteComponentProps): ReactElement;
-  renderText(props: RemoteTextProps): ReactElement;
+  renderComponent(props: RemoteComponentProps): ReactNode;
+  renderText(props: RemoteTextProps): ReactNode;
 }
 
 export interface RenderComponentOptions {