Remove obsolete OneAncestorPerLine cop

Since `require_ancestor` no longer accepts arguments, this cop is obsolete.
Shopify · Mar 19, 2024 · d8fb2c6 · d8fb2c6
1 parent 51cf5f2
commit d8fb2c6
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 298 deletions.
diff --git a/config/default.yml b/config/default.yml
@@ -200,11 +200,6 @@ Sorbet/BuggyObsoleteStrictMemoization:
   Safe: true
   SafeAutoCorrect: false
 
-Sorbet/OneAncestorPerLine:
-  Description: 'Enforces one ancestor per call to requires_ancestor'
-  Enabled: false
-  VersionAdded: '0.6.0'
-
 Sorbet/RedundantExtendTSig:
   Description: >-
     Forbid the usage of redundant `extend T::Sig`.

diff --git a/config/obsoletion.yml b/config/obsoletion.yml
@@ -3,3 +3,6 @@
 #
 # See: https://docs.rubocop.org/rubocop/extensions.html#config-obsoletions
 #
+removed:
+  Sorbet/OneAncestorPerLine:
+    reason: '`require_ancestor` now takes a block instead of arguments'
diff --git a/lib/rubocop/cop/sorbet/one_ancestor_per_line.rb b/lib/rubocop/cop/sorbet/one_ancestor_per_line.rb
diff --git a/lib/rubocop/cop/sorbet_cops.rb b/lib/rubocop/cop/sorbet_cops.rb
@@ -10,7 +10,6 @@
 require_relative "sorbet/forbid_type_aliased_shapes"
 require_relative "sorbet/forbid_untyped_struct_props"
 require_relative "sorbet/implicit_conversion_method"
-require_relative "sorbet/one_ancestor_per_line"
 require_relative "sorbet/callback_conditionals_binding"
 require_relative "sorbet/forbid_t_struct"
 require_relative "sorbet/forbid_t_unsafe"

diff --git a/spec/rubocop/cop/sorbet/one_ancestor_per_line_spec.rb b/spec/rubocop/cop/sorbet/one_ancestor_per_line_spec.rb