This is a strict aliasing issue, right?

Shopify · Feb 19, 2021 · 5996255 · 5996255
1 parent 4b4d91c
commit 5996255
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/darray.h b/darray.h
@@ -167,7 +167,8 @@ rb_darray_make_impl(void *ptr_to_ary, int32_t array_size, size_t header_size, si
     meta->size = array_size;
     meta->capa = array_size;
 
-    *ptr_to_ptr_to_meta = meta;
+    // Write out result with memcpy to avoid strict aliasing issue.
+    memcpy(ptr_to_ptr_to_meta, &meta, sizeof(meta));
     return 1;
 }