Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Commit

Permalink
Fix recurring app charge currency type
Browse files Browse the repository at this point in the history
  • Loading branch information
paulomarg committed Apr 5, 2024
1 parent 4b31178 commit 513f9e6
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 42 deletions.
5 changes: 5 additions & 0 deletions .changeset/young-hotels-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@shopify/shopify-api": patch
---

Fixed an issue with the `RecurringApplicationCharge` REST resource currency type
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.October22;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.January23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.April23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.July23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.October23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.January24;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.April24;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down

0 comments on commit 513f9e6

Please sign in to comment.