[tapioca add-on] Bump depend_on_ruby_lsp! version #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
changed the title
alexcrocha
approved these changes
Oct 11, 2024
KaanOzkan
reviewed
Oct 11, 2024
lib/ruby_lsp/tapioca/addon.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| # typed: strict | |||
| # frozen_string_literal: true | |||
|
|
|||
| RubyLsp::Addon.depend_on_ruby_lsp!(">= 0.19.1", "< 0.20") | |||
| RubyLsp::Addon.depend_on_ruby_lsp!(">= 0.20", "< 0.21") | |||
There was a problem hiding this comment.
Is it possible to change it locally instead during development? I'm afraid of it degrading the internal testing since Ruby LSP isn't automatically bumped right away in my experience. I don't know the bumping logic and would like to learn also.
There was a problem hiding this comment.
I didn't notice the upper bound so ignore what I said above, it's better than failing to activate because Ruby LSP is too new.
There was a problem hiding this comment.
👍 (and have updated to match the latest release).
KaanOzkan
approved these changes
Oct 17, 2024
lib/ruby_lsp/tapioca/addon.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| # typed: strict | |||
| # frozen_string_literal: true | |||
|
|
|||
| RubyLsp::Addon.depend_on_ruby_lsp!(">= 0.19.1", "< 0.20") | |||
| RubyLsp::Addon.depend_on_ruby_lsp!(">= 0.20", "< 0.21") | |||
There was a problem hiding this comment.
I didn't notice the upper bound so ignore what I said above, it's better than failing to activate because Ruby LSP is too new.
andyw8
force-pushed
the
andyw8/bump-ruby-lsp-depend-on-version
branch
from
2a7cbae
to
02d4b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that I can point to Ruby LSP's
mainduring development.