Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump expected rack version in tests #2046

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Bump expected rack version in tests #2046

merged 1 commit into from
Oct 15, 2024

Conversation

KaanOzkan
Copy link
Contributor

@KaanOzkan KaanOzkan requested a review from a team as a code owner October 15, 2024 18:39
amomchilov
amomchilov approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@amomchilov amomchilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be preferable to make these expectations "looser", so this doesn't need to be maintained?

@KaanOzkan
Copy link
Contributor Author

Yeah I think it's fine to add support for a assert_rbi_exists in spoom with a wildcard. I'll take a look.

@KaanOzkan KaanOzkan merged commit 03b121b into main Oct 15, 2024
29 of 30 checks passed
@KaanOzkan KaanOzkan deleted the ko/fix-ci-3 branch October 15, 2024 19:24
This was referenced Oct 15, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amomchilov amomchilov amomchilov approved these changes

@Morriar Morriar Awaiting requested review from Morriar Morriar is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaanOzkan @amomchilov