[Tapioca Add-on] Optimize File Save Handling #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrocha
force-pushed
the
ar/handle-repeat-saves
branch
from
99c8bd8
to
68d7882
Compare
andyw8
reviewed
Oct 22, 2024
By leveraging file checksums using `Zlib.crc32`, we can avoid triggering the DSL generation process for files that have not changed.
alexcrocha
force-pushed
the
ar/handle-repeat-saves
branch
from
68d7882
to
5e51a3a
Compare
alexcrocha
changed the title
andyw8
approved these changes
Oct 24, 2024
andyw8
reviewed
Oct 24, 2024
| current_checksum = Zlib.crc32(content).to_s | ||
|
|
||
| if change[:type] == Constant::FileChangeType::CHANGED && @file_checksums[path] == current_checksum | ||
| $stderr.puts "File has not changed. Skipping #{path}" |
There was a problem hiding this comment.
This might be a little noisy to show every time, but we can keep it for now.
There was a problem hiding this comment.
Good point. Let's monitor it and I'll remove if it's too much.
KaanOzkan
approved these changes
Oct 24, 2024
alexcrocha
changed the title
alexcrocha
changed the title
alexcrocha
merged commit 258e290
into
tapioca-addon-feature-branch
14 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, each file save triggers DSL generation, even when there are no code changes. This leads to unnecessary processing. This PR addresses the issue by optimizing the save handling process.
Implementation
Implemented a checksum-based approach using
Zlib.crc32. By calculating and storing file checksums, we can skip DSL generation for unchanged files, reducing redundant processing.