[RFC] Don't replace proxy with random port in AddOrReplace #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When asking ProxyCollection to `AddOrReplace` a proxy with a random listening port (`:0`), don't stop and replace an existing one with the same `name` and `upstream`.
miry
reviewed
Jan 13, 2022
| func TestAddOrReplaceProxyToCollectionWithRandomPort(t *testing.T) { | ||
| collection := toxiproxy.NewProxyCollection() | ||
| proxy1 := NewTestProxy("test", "localhost:20000") | ||
| proxy2 := NewTestProxy("test", "localhost:0") |
There was a problem hiding this comment.
As I understand the Listen for NewTestProxy is always "localhost:0". The second argument is upstream.
miry
reviewed
Jan 13, 2022
| if err != nil { | ||
| return err | ||
| } | ||
| if port == "0" { |
There was a problem hiding this comment.
I would add also empty port to same ( Listen = "" works the same as ":0")
// If the port in the address parameter is empty or "0", as in
// "127.0.0.1:" or "[::1]:0", a port number is automatically chosen.
// The Addr method of Listener can be used to discover the chosen
// port.
https://play.golang.com/p/qXvL6s63ZbE
func main() {
var port string
listens := []string{
"",
"localhost",
"localhost:0",
":0",
}
for _, listen := range listens {
_, port, _ = net.SplitHostPort(listen)
fmt.Printf("port for '%s': %v\n", listen, port)
}
}
output:
port for '':
port for 'localhost':
port for 'localhost:0': 0
port for ':0': 0
|
Clossing for now. Pls reopen if it is still required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asking ProxyCollection to
AddOrReplacea proxy with a randomlistening port (
:0), don't stop and replace an existing one withthe same
nameandupstream.