Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update merge to >2.1.1 for security issue #244

Merged
merged 2 commits into from
May 5, 2021
Merged

Update merge to >2.1.1 for security issue #244

merged 2 commits into from
May 5, 2021

Conversation

vsumner
Copy link
Contributor

@vsumner vsumner commented May 5, 2021 •
edited
Loading

Description

Update merge to 2.1.1 for security issue.

GHSA-7wpw-2hjm-89gp

Type of change

  • @shopify/eslint-plugin Patch: Bug (non-breaking change which fixes an issue)
    expected)
  • @shopify/stylelint-plugin Patch: Bug (non-breaking change which fixes an issue)
    expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@vsumner vsumner requested review from melodyhabbouche and a team May 5, 2021 15:10
@vsumner vsumner marked this pull request as ready for review May 5, 2021 15:10
melodyhabbouche
melodyhabbouche approved these changes May 5, 2021
View reviewed changes
Copy link

@melodyhabbouche melodyhabbouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

dahukish
dahukish approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@dahukish dahukish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vsumner vsumner merged commit cb50828 into main May 5, 2021
@vsumner vsumner deleted the update-merge branch May 5, 2021 15:19
@shopify-shipit shopify-shipit bot temporarily deployed to production May 5, 2021 17:27 Inactive
@shopify-shipit shopify-shipit bot deployed to fix-loose-issue August 18, 2021 00:44 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melodyhabbouche melodyhabbouche melodyhabbouche approved these changes

@dahukish dahukish dahukish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsumner @dahukish @melodyhabbouche