Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #327. Fixes #320.
Part of https://github.com/Shopify/web/issues/55503.
eslint-plugin-graphql
is outdated and unsupported. Consumers should use@graphql-eslint/eslint-plugin
to lint their graphql files.I am choosing to remove
eslint-plugin-graphql
without replacement because graphql linting has a large install footprint, and we should not burden consumers that do not use graphql with having to install those additional dependencies.Upon updating to v42, consumers that currently extend from
plugin:@shopify/graphql
can instead add the following to their eslint config:This PR:
graphql
config. Extending fromplugin:@shopify/graphql
will cause an error as that config no longer exists.eslint-plugin-graphql