feat: add default value None for optional members (smithy-lang#305)

* feat: add default value None for optional members
ShubhamChaturvedi7 · Feb 24, 2024 · fdcf416 · fdcf416
1 parent e027e4d
commit fdcf416
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...hy-dafny-codegen/src/main/java/software/amazon/polymorph/smithydafny/DafnyApiCodegen.java b/...hy-dafny-codegen/src/main/java/software/amazon/polymorph/smithydafny/DafnyApiCodegen.java
@@ -375,8 +375,12 @@ public TokenTree generateWrappedDataTypeConstructorFromUnionMember(final MemberS
     }
 
     private TokenTree generateStructureTypeParameter(final MemberShape memberShape) {
-        return Token.of("nameonly %s: %s".formatted(
-                memberShape.getMemberName(), nameResolver.baseTypeForShape(memberShape.getId())));
+        String dflt = "";
+        if (ModelUtils.memberShapeIsOptional(model, memberShape)) {
+            dflt = " := Option.None";
+        }
+        return Token.of("nameonly %s: %s%s".formatted(
+            memberShape.getMemberName(), nameResolver.baseTypeForShape(memberShape.getId()), dflt));
     }
 
     public TokenTree generateServiceTraitDefinition(ServiceShape serviceShape) {

diff --git a/...afny-codegen/src/test/java/software/amazon/polymorph/smithydafny/DafnyApiCodegenTest.java b/...afny-codegen/src/test/java/software/amazon/polymorph/smithydafny/DafnyApiCodegenTest.java
@@ -189,9 +189,9 @@ public void testGenerateStructureTypeDefinition() {
 
         final List<ParseToken> expectedTokens = Tokenizer.tokenize("""
                 datatype Foobar = | Foobar(
-                    nameonly someInt: Option<int32>,
-                    nameonly someString: Option<string>,
-                    nameonly someBool: bool
+                   nameonly someInt: Option<int32> := Option.None,
+                   nameonly someString: Option<string> := Option.None,
+                   nameonly someBool: bool
                 )
                 """);
         assertEquals(expectedTokens, actualTokens);