David/upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasPrice should be encoded as rpc quantity hex
Stop the engine when we stop the provider. fix a bug caused by it
Pin version of ethereumjs-wallet to 0.6.0
Also had to tweak the `add`/`transfer` gas estimation tests as on `transfer` we'll estimate `15000` too high due to the `transfer` call setting storage back to `0` (and we don't account for this `15000` refund in our estimate). To work around the issue I increased the amount initially added to the recipient to `10` so that transfering `5` out in the transfer test doesn't set it to `0`.
…s will work I wanted to test against geth using the web3 http provider and it wouldn't work the way the tests were written.
Add User-Agent token to allowed headers
Prior to this change, the `gasPrice` set in the `options` object wasn't respected, and neither gasPrice nor gasLimit were documented in our README.md. This change also adds tests for these options. fixes trufflesuite#314
make requests tests async
All the block filter methods are already implemented in: https://github.com/MetaMask/provider-engine/blob/master/subproviders/filters.js#L144-L175 This is just cleaning up some methods that slipped past the RPC audit.
Add regression test for gas estimate for simple value transfer between accounts. There was previously a same-day hot fix on a release for this issue, but there was no time for the test at that moment... so here is the test!
…e#212) getTransactionReceipt was not previously returning a `to` and `from` address field. This PR adds those fields to the transaction receipt.
Both geth and parity respond with null as the output. This updates ganache to match.
If the string is not found indexOf returns -1 !!-1 === true This fixes a potential 'misfire' on this if statement and further strengthens the condition itself with a more specific string match
…test Fix to handle requests with block numbers greater than latest
* stop mining on close * when closing provider do not pass callback to stopMining * add test * fix that new mining test * fix race condition in mineOnInterval * update tests
Make sure ganache-core doesn't get published with devDependencies in its npm-shrinkwrap.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.