ValueError (Delete)

[Ysnz]

Description

When attempting to delete an object in the admin interface, an internal server error occurs. The error is specifically related to the attempt to convert a UUID ('90b608d0-1684-4b5e-adf3-fb5c0c21ca96') to an integer during the deletion process.

How To Reproduce

Steps to reproduce the behavior:

1. Go to the admin interface.
2. Navigate to the page where you can delete an object.
3. Attempt to delete an object with the UUID '90b608d0-1684-4b5e-adf3-fb5c0c21ca96'.
4. Observe the internal server error.

Expected behavior

The deletion process should occur without errors, and the object with the provided UUID should be deleted successfully.

Additional context

The issue is related to the attempt to convert UUIDs to integers during the deletion process, resulting in a ValueError.

Screenshots

[KengoWada]

Hey @Ysnz thanks for reporting the bug. I'm going to try and replicate it to confirm the bug.

[KengoWada]

Hey @EricOuma I can confirm the bug that has been reported. I will start working on a fix. Please assign this to me and mark it as a bug.

[EricOuma]

@KengoWada Let me know how you plan to approach the problem before you make a PR.

[KengoWada]

@EricOuma this is my current solution in collections.py
TypesenseCollection.delete

- delete_params = {"filter_by": f"id:{[int(obj['id']) for obj in self.data]}"}

+ object_ids = []
+ for obj in self.data:
+     try:
+         object_id = int(obj["id"])
+     except ValueError:
+         object_id = str(obj["id"])
+     object_ids.append(object_id)
+
+ if all(isinstance(id_, int) for id_ in object_ids):
+     filter_by = f"id:{object_ids}"
+ else:
+     filter_by = f"id: {object_ids}".replace("'", "")
+
+ delete_params = {"filter_by": filter_by}

WDYT

[EricOuma]

What happens if you don't convert it to an integer at all; just using the id as is. I don't think typesense is aware that its an integer.

…

On Fri, 9 Feb 2024, 18:31 Kengo Wada, ***@***.***> wrote: @EricOuma <https://github.com/EricOuma> this is my current solution - delete_params = {"filter_by": f"id:{[int(obj['id']) for obj in self.data]}"} + object_ids = []+ for obj in self.data:+ try:+ object_id = int(obj["id"])+ except ValueError:+ object_id = str(obj["id"])+ object_ids.append(object_id)++ if all(isinstance(id_, int) for id_ in object_ids):+ filter_by = f"id:{object_ids}"+ else:+ filter_by = f"id: {object_ids}".replace("'", "")++ delete_params = {"filter_by": filter_by} WDYT — Reply to this email directly, view it on GitHub <#72 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH4HSZEGQFOFI5D5AQQL5XLYSY6LNAVCNFSM6AAAAABCKT77FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGEZTKNRYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[KengoWada]

@EricOuma Yeah, that's the way to go. You need to remove the single quotes that Python adds to strings. According to Typesense filter_by formatting rules.

- delete_params = {"filter_by": f"id:{[int(obj['id']) for obj in self.data]}"}
+ delete_params = {"filter_by": f"id: {[obj['id'] for obj in self.data]}".replace("'", "")}