Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for model mixin #27

Closed

Conversation

KengoWada
Copy link
Collaborator

Closes #25

Added tests for TypesenseModelMixin

Changes made

  • Added test settings
  • Added test models and collections
  • Added Django test runner
  • Fixed TypesenseCollection delete method to convert object ids to int
  • Updated CONTRIBUTIONS.md to reflect changes in tests.

@KengoWada KengoWada marked this pull request as ready for review October 23, 2023 19:45
@KengoWada
Copy link
Collaborator Author

Hey @EricOuma could you please approve the workflows for this PR. Thanks

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (4968cd7) 100.00% compared to head (13b668e) 59.62%.

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #27       +/-   ##
============================================
- Coverage   100.00%   59.62%   -40.38%     
============================================
  Files            1       10        +9     
  Lines           12      426      +414     
============================================
+ Hits            12      254      +242     
- Misses           0      172      +172     
Files Coverage Δ
django_typesense/collections.py 59.06% <55.26%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KengoWada
Copy link
Collaborator Author

I'll be closing this PR because it contains unsigned commits.

@KengoWada KengoWada closed this Oct 28, 2023
@KengoWada KengoWada deleted the 25-ch/add-tests-for-model-mixin branch October 28, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for model mixin
2 participants