Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for model mixin #29

Merged

Conversation

KengoWada
Copy link
Collaborator

Resolves #25

Added tests for TypesenseModelMixin

Changes made

  • Added test settings
  • Added test models and collections
  • Added Django test runner
  • Fixed TypesenseCollection delete method to convert object ids to int
  • Updated CONTRIBUTIONS.md to reflect changes in tests.
  • Updated GitHub actions to include TypeSense

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (cf788bd) 100.00% compared to head (e0bd091) 60.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #29       +/-   ##
============================================
- Coverage   100.00%   60.36%   -39.64%     
============================================
  Files            1       10        +9     
  Lines           12      439      +427     
============================================
+ Hits            12      265      +253     
- Misses           0      174      +174     
Files Coverage Δ
django_typesense/collections.py 55.97% <60.46%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricOuma
Copy link
Contributor

Some of the skeleton code I added for the tests are slightly obsolete. The tests you have added are actually for test_typesense_collection and not test_typesense_model_mixin

@KengoWada
Copy link
Collaborator Author

Some of the skeleton code I added for the tests are slightly obsolete. The tests you have added are actually for test_typesense_collection and not test_typesense_model_mixin

Hey @EricOuma noted. I've updated the tests to target django_typesense.mixins

@EricOuma EricOuma merged commit 459224c into Siege-Software:main Nov 1, 2023
9 checks passed
@KengoWada KengoWada deleted the 25-ch/add-tests-for-model-mixin branch November 20, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for model mixin
3 participants