Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added m2m_changed signal #30

Merged

Conversation

KengoWada
Copy link
Collaborator

Resolves #26

Added m2m_changed signal for django_typesense models

Changes made

  • Added m2m_changed_typesense_models to handle ManyToManyField changes
  • Added tests for django_typesense.signals
  • Added tests.utils to contain get_document
  • Updated test_typesense_model_mixin to use new get_document from utils

@KengoWada KengoWada changed the title 26 bug fix/add m2m changed signal Added m2m_changed signal Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (459224c) 60.36% compared to head (0fdd1b9) 61.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   60.36%   61.46%   +1.10%     
==========================================
  Files          10       10              
  Lines         439      449      +10     
==========================================
+ Hits          265      276      +11     
+ Misses        174      173       -1     
Files Coverage Δ
django_typesense/signals.py 100.00% <100.00%> (+7.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KengoWada
Copy link
Collaborator Author

Hey @EricOuma please review my PR. Thanks

@EricOuma
Copy link
Contributor

EricOuma commented Nov 6, 2023 via email

@EricOuma EricOuma merged commit 1261b7a into Siege-Software:main Nov 7, 2023
9 checks passed
@KengoWada KengoWada deleted the 26-bug-fix/add_m2m_changed_signal branch November 20, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add m2m_changed signal
3 participants