Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelist and admin and readme #46

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

EricOuma
Copy link
Contributor

Resolves #42

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (b22a974) 60.61% compared to head (92a51cd) 59.84%.

Files Patch % Lines
django_typesense/utils.py 16.66% 10 Missing ⚠️
django_typesense/fields.py 45.45% 6 Missing ⚠️
django_typesense/collections.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   60.61%   59.84%   -0.77%     
==========================================
  Files          10       10              
  Lines         490      518      +28     
==========================================
+ Hits          297      310      +13     
- Misses        193      208      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KengoWada KengoWada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricOuma code LGTM

@EricOuma EricOuma merged commit ef8d9fc into main Nov 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target specific field when updating collections
3 participants