Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils file #58

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Conversation

KengoWada
Copy link
Collaborator

Resolves #52

Proposed changes

  • Updated the Exceptions to more exact Exceptions.
  • Added custom exceptions BatchUpdateError, UnorderedQuerySetError
  • Fixed objs to objects
  • Added model factories to make creating test objects easier
  • Added factory-boy to dev dependencies
  • Updated utils docstrings for uniformity following numpydoc style.

Types of changes

What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@KengoWada KengoWada changed the title 52 ch/update utils Update utils file Nov 28, 2023
@KengoWada
Copy link
Collaborator Author

@EricOuma please review this. Thanks

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6e79c21) 71.75% compared to head (1959c5a) 79.50%.

❗ Current head 1959c5a differs from pull request most recent head 4d03d8c. Consider uploading reports for the commit 4d03d8c to get more accurate results

Files Patch % Lines
django_typesense/admin.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   71.75%   79.50%   +7.75%     
==========================================
  Files          11       12       +1     
  Lines         563      571       +8     
==========================================
+ Hits          404      454      +50     
+ Misses        159      117      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricOuma
Copy link
Contributor

EricOuma commented Dec 4, 2023

Hello @KengoWada. I've been busy on other stuff. There is an urgent fix I needed to make on main. Please look into the conflicts.

@KengoWada
Copy link
Collaborator Author

@EricOuma done. Please review. Thanks

@EricOuma EricOuma merged commit cb06487 into Siege-Software:main Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update utils file.
3 participants