Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define get_search_results to fix autocomplete search errors #69

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

EricOuma
Copy link
Contributor

Resolves #67

Proposed changes

The AutoCompleteView uses get_search_results at some point with uses get_search_fields. Because some of the search fields defined are for typesense and not the model, an error occurred when the Django ORM tried to use such fields.
This PR overrides the get_search_results method so that it can be used in a typesense safe way.

Types of changes

What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@KengoWada KengoWada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricOuma code LGTM.

@EricOuma EricOuma merged commit 1f05f1e into main Jan 2, 2024
9 checks passed
@EricOuma EricOuma deleted the 67-admin-autocomplete-fields-are-not-working branch January 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin autocomplete fields are not working
2 participants