Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use django's cl.get_request as is to avoid poor performance #73

Merged

Conversation

EricOuma
Copy link
Contributor

@EricOuma EricOuma commented Feb 9, 2024

Resolves # (issue)

Proposed changes

Typesense has a maximum pagination size of 250. This interferes with admin actions that have more than 250 items selected

Types of changes

What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d458743) 78.91% compared to head (d0dad17) 78.64%.

Files Patch % Lines
django_typesense/admin.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   78.91%   78.64%   -0.28%     
==========================================
  Files          12       12              
  Lines         574      576       +2     
==========================================
  Hits          453      453              
- Misses        121      123       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricOuma EricOuma merged commit f6ebe69 into main Feb 9, 2024
9 checks passed
@EricOuma EricOuma deleted the make-admin-actions-use-djangos-queryset-instead-of-typesense branch February 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants