Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typeerror raised when updating single work #84

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

EricOuma
Copy link
Contributor

@EricOuma EricOuma commented Apr 3, 2024

Resolves # (issue)

Proposed changes

TypeError
string indices must be integers
File "django_typesense/utils.py", line 42, in update_batch
    failure_responses = [response for response in responses if not response["success"]]
  File "django_typesense/utils.py", line 42, in <listcomp>
    failure_responses = [response for response in responses if not response["success"]]

An update on a single object returns a dictionary not a list

Types of changes

What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@EricOuma EricOuma merged commit df19765 into main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant