add new validator - DanglingCondition #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new validator -
DanglingCondition
Motivation
In certain edge cases, a sigma rule author might reference an unknown detection definition from the condition in the form of
1 of something
. Example:Currently pySigma gracefully handles the conversion without error but this might lead to confusion in certain tools and the semantically the rule contain an "error".
Solution
This PR adds a new validator that is very similar to the DanglingDetection. The difference being the use of the fact that when a ConditionSelector calls
resolve_referenced_detections
it will return an empty set if the detection definition doesn't exist (i.e match any patterns).