-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: remove Lookahead
regular expressions
#4526
update: remove Lookahead
regular expressions
#4526
Conversation
For example, the code using I think it's difficult to support regular expressions for all languages... :(, |
look ahead
regular expressionsLookahead
regular expressions
@nasbench |
I may also be misunderstanding the specifications of The regular expression below is Is it assumed that it will be converted to the following regular expression? If I can write the normal IP address pattern as a not filter, I might be able to avoid using |
Lookahead
regular expressionsLookahead
regular expressions
Lookahead
regular expressionsLookahead
regular expressions
@nasbench |
I found that there was some discussion about regular expression specifications in this issue. |
rules/windows/process_creation/proc_creation_win_susp_obfuscated_ip_download.yml
Outdated
Show resolved
Hide resolved
rules/windows/process_creation/proc_creation_win_susp_obfuscated_ip_download.yml
Outdated
Show resolved
Hide resolved
Hey @fukusuket thanks for the update. I like the filter idea that will make it more generic for different backends :) Thanks. |
Summary of the Pull Request
Removed
unnecessaryLookahead
regular expressions because it is a syntax not supported by some programming languages like Golang, Rust.I think this rule will not be hit in most cases because of the
(?!.)
at the end. So I removed(?!.)
What do you think?(If you want to clearly indicate that there is no character (other than a newline), I think$
would be fine?)I'm sorry if I misunderstood the intent of this regular expression...
Changelog
update: Obfuscated IP Download Activity
Example Log Event
N/A
Fixed Issues
N/A
SigmaHQ Rule Creation Conventions