Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on tv4-formats #498

Closed
wants to merge 1 commit into from

Commits on Aug 15, 2018

  1. chore: remove dependency on tv4-formats

    TV4-Format provides some JSON validation helper for common string
    formats. It was loaded only when validating the full model (not delta)
    and all the tests run without it so I propose we remove it.
    
    Reason for me looking into this is that this library causes problem with
    webpack because of a heuristic they use to require one of their
    dependency. This is a known issue that they have fixed in a later
    version and I have confirmed that upgrading the package fixes the issue
    for us too. However, if we do not use the library I think it's better to
    completely remove it.
    
    For more info: ikr/tv4-formats@61450dc
    sarfata committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    dd4ac8c View commit details
    Browse the repository at this point in the history