Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport code prawn to correctly render colspan table cells #17

Merged
merged 1 commit into from
May 9, 2022

Conversation

TheSmartnik
Copy link

Ports the following prs:
prawnpdf#712
prawnpdf#620

@radanskoric
Copy link

@TheSmartnik it's not really clear from the PR so I'll ask:

  1. Have you only added the patches from the two prawn PRs without modification? Did you run into any git conflicts that you had to resolve when doing that?

  2. What is the problem that this is solving on our side? How did you identify this as the appropriate fix?

I can't easily follow these changes in prawn codebase so I'm asking these changes to better understand all the steps taken.

@TheSmartnik
Copy link
Author

TheSmartnik commented May 5, 2022

@radanskoric

Have you only added the patches from the two prawn PRs without modification? Did you run into any git conflicts that you had to resolve when doing that?

Yes, I haven't modified anything and haven't run into any conflicts

What is the problem that this is solving on our side?

The problem is best described here https://gitlab.silverfin.com/development/silverfin/-/merge_requests/14992
Do you want me to copy this info here for future reference?

How did you identify this as the appropriate fix?

  1. Mr I've mentioned above contains screenshots before/after
  2. PST manually tested it
  3. We've run exports sampler for provided by PST export ids

@radanskoric
Copy link

Looks good, tested it a bit, don't see any issues. I'm approving and I'll let you merge it when appropriate so you can coordinate with the Sf MR.

@TheSmartnik TheSmartnik merged commit a673a0d into master May 9, 2022
@TheSmartnik TheSmartnik deleted the nikitam-port-colspan-fixes branch May 9, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants