Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change starting time of day view" #134

Conversation

ParthBaraiya
Copy link
Collaborator

Reverts #112

Need to discuss more scenarios, For example we have DayView set with startTime of 4, Then it will start the DayView page at 4 AM and move 1-3 AM at the bottom of the page. Now,

  • How will the events that is scheduled for 2 to 4 AM will be displayed? Should the event be displayed in previous day page or we will not display the event at all.
  • Should we display the 1-3 AM time slots or will it be completely removed?
  • Should we only provide startTime or developer can define the range. As example, developer can define Time from 10AM to 6 PM So, DavView will only display events that occurs between 10 AM to 6 PM.

@ParthBaraiya ParthBaraiya requested review from faiyaz-shaikh and vatsaltanna and removed request for vatsaltanna and faiyaz-shaikh November 19, 2022 15:44
@PRBaraiya PRBaraiya deleted the revert-112-feature/change_starting_time_of_day_view branch December 6, 2022 14:21
@marquezea
Copy link

I think this feature will be good since many use cases require showing the calendar during business hours.
Showing hours before 8 am or after 6 pm in many cases causes unnecessary scrolling.

My suggestion to implement this would be the following:

  • to start this feature should be applicable for both DayView and WeekView
  • there should exist two settings: displayStartHour (default 0) and displayEndHour (default 23)
  • based on these settings the DayView and WeekView should display only the hours within this range
    For instance:
    if displayStartHour is set to 10 and displayEndHour is set to 16 then only the rows 10 am,11 am,12 pm,13 pm,14 pm,15 pm,16 pm will be displayed with the corresponding events

When events are added outside of the display they shall remain in memory although not displayed in these views.
It would be the developer's responsibility to define the display range that he wants to show to the end user.

I hope this comment helps to define the final approach to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants