🚀 add option to provide week days to display in week. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthBaraiya
requested review from
DevarshRanpara and
vatsaltanna-simformsolutions
|
I think let's add one more property showWeekend and defaut it to true along with combination of this weekdays array. |
ParthBaraiya
force-pushed
the
feature/add_weekday_option
branch
3 times, most recently
from
029462c
to
b841745
Compare
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # 0.0.3 | |||
|
|
|||
| - Add support to choose which days should be displayed in a week in `WeekView`. | |||
There was a problem hiding this comment.
please mention the issue here
lib/src/extensions.dart
Outdated
| final day = weekday; | ||
| final start = subtract(Duration(days: day - startDay.index)); | ||
| final start = subtract(Duration(days: day - 1)); |
There was a problem hiding this comment.
why are we decreasing 1 day here ?
lib/src/week_view/week_view.dart
Outdated
| @@ -264,7 +313,7 @@ class WeekViewState<T> extends State<WeekView<T>> { | |||
| onPageChanged: _onPageChange, | |||
| itemBuilder: (_, index) { | |||
| final dates = _minDate | |||
| .add(Duration(days: (index - 1) * _weekDays)) | |||
| .add(Duration(days: (index - 1) * 7)) | |||
There was a problem hiding this comment.
use constant variables instead of direct value
ParthBaraiya
force-pushed
the
feature/add_weekday_option
branch
from
b841745
to
6f1bdc7
Compare
ParthBaraiya
requested review from
sanket-simform and
vatsaltanna-simformsolutions
| @@ -1,3 +1,7 @@ | |||
| # 0.0.3 | |||
There was a problem hiding this comment.
please mention this version as unreleased
| final weekDays = this.weekDays.toList() | ||
| ..sort((d1, d2) => d1.index - d2.index); | ||
|
|
||
| var i = 0; |
There was a problem hiding this comment.
variable name is not appropriate.
ParthBaraiya
force-pushed
the
feature/add_weekday_option
branch
2 times, most recently
from
54a4334
to
6b5c334
Compare
ParthBaraiya
force-pushed
the
feature/add_weekday_option
branch
from
6b5c334
to
9d854d0
Compare
ParthBaraiya
force-pushed
the
feature/add_weekday_option
branch
from
9d854d0
to
d217c57
Compare
vatsaltanna
approved these changes
Mar 2, 2022
vatsaltanna-simformsolutions
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.