Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛Added a callback for the header title #241. #253

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: 🐛Added a callback for the header title #241. #253

merged 1 commit into from
Nov 3, 2023

Conversation

jaiminrana05
Copy link
Collaborator

@jaiminrana05 jaiminrana05 commented Aug 10, 2023 •
edited
Loading

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#241

@jaiminrana05 jaiminrana05 force-pushed the fix/issue_241_header_callback_changes branch 2 times, most recently from be97b2d to d458691 Compare August 10, 2023 06:13
@jaiminrana05 jaiminrana05 linked an issue Aug 10, 2023 that may be closed by this pull request
Header change Spacific Callback #241
Closed
@PRBaraiya
Copy link
Collaborator

@jaiminrana05 Please resolve conflicts

@jaiminrana05 jaiminrana05 force-pushed the fix/issue_241_header_callback_changes branch from d458691 to ced2737 Compare November 1, 2023 14:45
@jaiminrana05 jaiminrana05 force-pushed the fix/issue_241_header_callback_changes branch from ced2737 to c1f9035 Compare November 2, 2023 10:52
@jaiminrana05 jaiminrana05 force-pushed the fix/issue_241_header_callback_changes branch from c1f9035 to 38be203 Compare November 2, 2023 10:52
PRBaraiya
PRBaraiya approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 2ef1d21 into master Nov 3, 2023
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_241_header_callback_changes branch November 3, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header change Spacific Callback
2 participants
@jaiminrana05 @PRBaraiya