Update NullabilityInfoContext.cs.pp with bug fix from MS repo

[Shane32]

See:

• Fix NullabilityInfoContext.Create to properly analyze types with nested generic types dotnet/runtime#63556

[Shane32]

@SimonCropp When using this source-only repo, does the code get injected for all frameworks, or only pre-.NET 6 frameworks? If the latter, is there any way to make this work in a .NET 6 environment, so that the fixed code is used rather than the buggy .NET 6 code?

[SimonCropp]

thanks for this. i will deploy it now.

When using this source-only repo, does the code get injected for all frameworks, or only pre-.NET 6 frameworks

only pre-.NET 6 frameworks

is there any way to make this work in a .NET 6 environment, so that the fixed code is used rather than the buggy .NET 6 code?

not currently. TBH it is no a scenario that i considered. although it is obviously valid. thoughts on how it could be achieved? perhaps via compilation constant?

[SimonCropp]

or i could deploy a new nuget that has all the types in a diff namespace

[Shane32]

Between me and another person, we have found a multitude of bugs with NullabilityInfoContext. But to be honest, it's unlikely most people would run into issues for my specific use case within GraphQL.NET.

Just for reference:

• Fix NullabilityInfoContext.Create to properly analyze types with nested generic types dotnet/runtime#63556
• NullabilityInfoContext returns incorrect result for parameter of private constructor in a public-only assembly dotnet/runtime#63853
• NullabilityInfoContext does not properly respect CodeAnalysis attribute on indexer property dotnet/runtime#63849
• NullabilityInfoContext returns incorrect result when code analysis attributes are used in a disabled context dotnet/runtime#63848
• NullabilityInfoContext returns incorrect result for some unannotated private members dotnet/runtime#63847
• NullabilityInfoContext reports incorrect result when mixing AllowNull and DisallowNull dotnet/runtime#63846
• NullabilityInfoContext reports null/notnull for unspecified generic parameters dotnet/runtime#63660
• NullabilityInfoContext does not report the correct nullability for method in generic base class. dotnet/runtime#63555

Plus another bug when a generic type definition of a generic class has a class constraint - but I have not created an issue yet.

or i could deploy a new nuget that has all the types in a diff namespace

I'll let you know if it would be beneficial. Thanks!!!

[sungam3r]

😕 What happens with the MS code?

[Shane32]

It is slated for .NET 7

[SimonCropp]

it should have been a nuget that is shipped out of band