Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows testing to travis-ci #115

Closed
wants to merge 2 commits into from
Closed

add windows testing to travis-ci #115

wants to merge 2 commits into from

Conversation

ahyork
Copy link
Collaborator

@ahyork ahyork commented Aug 6, 2019

No description provided.

@coveralls
Copy link

coveralls commented Aug 6, 2019

Pull Request Test Coverage Report for Build 492

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.958%

Totals Coverage Status
Change from base Build 433: 0.0%
Covered Lines: 1137
Relevant Lines: 1422

💛 - Coveralls

@ahyork
Copy link
Collaborator Author

ahyork commented Aug 6, 2019

Testing on Windows builds fails because CSV.jl doesn't ignore commented lines when the file has dos line endings on a windows machine. This issue has been reported here

@SimonEnsemble
Copy link
Owner

@ahyork looks like the PR for CSV.jl has been merged (see here). Feel free to revisit, but I will close the PR for now since the Travis CI tests are not passing.

@SimonEnsemble SimonEnsemble deleted the travis_windows branch June 26, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants