Allow macOS Debug pipeline to fail -> checking for memory alloc #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fabinsch
commented
Nov 16, 2022
fabinsch
commented
- currently we check for runtime memory allocations in this one specific pipeline
- we still observe a few during the dense solve, but we don't want to PRs to be marked as failed, it's a way to keep track of mem allocs but no critical failure
- currently we check for runtime memory allocations in this one specific pipeline - we still observe a few during the dense solve, but we dont want to PRs to be marked as failed, it's a way to keep track of mem allocs but no critical failure
jcarpent
previously approved these changes
Nov 16, 2022
- due to our include structure we have to specifically exclude this cfg otherwise we have two macOS Debug c++17
fabinsch
force-pushed
the
topic/ci-continue-on-error
branch
from
7a45f6a
to
1c29790
Compare
fabinsch
force-pushed
the
topic/ci-continue-on-error
branch
from
d8dbcc0
to
7ff8cff
Compare
|
Hey @jcarpent, now it is fine. I needed to do some tests but now even though we have some tests failing due to mem allocation here we get a PR with green light. |
fabinsch
changed the title
jcarpent
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.