add is_valid function for dense model and fix example + unittest #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computing timings may slow down the overall performances of the solver
auto-merge was automatically disabled
December 14, 2022 09:54
Pull request was converted to draft
- H needs to be a full matrix and not only upper triangular - C should not be only containing zeros -> lower sparsity - set a random seed
for more information, see https://pre-commit.ci
jcarpent
reviewed
Dec 14, 2022
- same is done for not-windows - by default we have a seed
- in discussion with @Bambade: the ruiz equilibrator itself can handle H that is only the upper or triangular matrix - the full pipeline of the dense backend needs the entire H matrix
jcarpent
reviewed
Dec 14, 2022
jcarpent
requested changes
Dec 14, 2022
jcarpent
approved these changes
Dec 14, 2022
fabinsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had timeouts in debug mode on windows because the bounds were updated in the wrong order and it took too long to reach the maximum number of iterations.