Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scoreboard suffix #10

Closed
wants to merge 3 commits into from
Closed

Conversation

Fulminazzo
Copy link
Contributor

Apparently there is a bug with scoreboard-library from version 2.1.0 for which the prefix will be displayed as both the prefix and the suffix in scoreboard.
You can verify this in TablistRankHeader at line 68:

display.suffix(MiniMessage.miniMessage().deserialize(
    this.plugin.getConfig().getString("group-suffix", ""),
    MiniPlaceholders.getAudienceGlobalPlaceholders(player)
));

System.out.println(this.plugin.getConfig().getString("group-suffix", "")); // Returns the correct value
System.out.println(display.suffix()); // Returns the value previously set in display.prefix()

Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Netherwhal
Copy link
Contributor

apologies @Fulminazzo for this, it was indeed due to upstream and will be fixed shortly: MegavexNetwork/scoreboard-library@da176b8

@Netherwhal Netherwhal closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants