Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path replace fail when dirname has same ext #179

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

heycalmdown
Copy link
Contributor

There are some projects which have an extname on its project name. According the results of the query from npmjs.com... - https://www.npmjs.com/search?q=.js

Let's say that we are making a project named abc.js on TypeScript; We are building something on the directory like below,

/Users/heycalmdown/development/abc.js$ npm run lcov-remap

The coverage/lcov.info will start with

TN:
SF:/Users/heycalmdown/development/abc.js/dist/index.js

And the remap file starts with

TN:
SF:/Users/heycalmdown/development/abc.ts/dist/index.js

Expected result is

TN:
SF:/Users/heycalmdown/development/abc.js/dist/index.ts

@dylans dylans merged commit 485b6f7 into SitePen:master Nov 26, 2018
@dylans
Copy link
Contributor

dylans commented Nov 26, 2018

Thanks for the fix, the test failure is due to other things, so I've gone ahead and landed this.

@dylans dylans added this to the 0.13.0 milestone Nov 26, 2018
@heycalmdown heycalmdown deleted the fix-pathname-has-same-ext branch June 30, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants