Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code coverage configuration #182

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Update code coverage configuration #182

merged 2 commits into from
Dec 28, 2018

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Dec 27, 2018

codecov.io has been superseded by codecov-node, but in any case the bash script is the preferred approach.

This PR:

  • Removes codecov.io from devDependencies (which also reduces vulnerable dependencies to zero!)
  • Uses the codecov.io bash script in the CI script
  • Adds coverage configuration to the Intern config

It has been tested and confirmed to upload coverage information to https://codecov.io/

After merging this should restore functionality of the codecov badge in the project's readme.

Update Intern config for code coverage
@dylans dylans added this to the 0.13.0 milestone Dec 28, 2018
@dylans dylans merged commit 195ca8d into master Dec 28, 2018
@msssk msssk deleted the codecov-test branch December 28, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants