Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-sitecore-jss] New initializer journey for Angular #1845

Merged

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jul 22, 2024

Description / Motivation

Angular will have XMC-only logic. This PR makes preparations for the new create-sitecore-jss init journey for Angular.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

(cherry picked from commit 6a9058d)
(cherry picked from commit 9501b26)
(cherry picked from commit f90190b)
(cherry picked from commit 60aadf7)
@art-alexeyenko art-alexeyenko requested a review from a team July 22, 2024 01:40
@art-alexeyenko art-alexeyenko changed the base branch from dev to feature/angular-xmc-proxy July 22, 2024 01:53
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@art-alexeyenko art-alexeyenko merged commit 6eb8615 into feature/angular-xmc-proxy Jul 23, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-3563-angular-init-journey branch July 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants