Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore][nextjs] Install sharp dependency for nextjs apps #1859

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jul 26, 2024

  • This PR follows the Contribution Guide
  • Changelog updated TBA
  • Upgrade guide entry added TBA

Description / Motivation

Install sharp in nextjs apps by default. https://nextjs.org/docs/messages/sharp-missing-in-production
Having sharp installed is recommended by Vercel to avoid issues with image optimization:
Version is locked to 0.32.6 due to this potential issue: vercel/next.js#59516 (comment)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - app starts as before

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

@art-alexeyenko art-alexeyenko requested a review from a team July 26, 2024 18:17
@art-alexeyenko art-alexeyenko merged commit 6d3b039 into dev Jul 26, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the chore/jss-3682-install-sharp branch July 26, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants