Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template/angular-xmcloud] Introduce angular SXA PartialDesignDynamicPlaceholder component #1902

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[template/angular-xmcloud] Introduce angular SXA PartialDesignDynamicPlaceholder component #1902

merged 3 commits into from
Aug 22, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Aug 22, 2024 •
edited
Loading

Description / Motivation

Introduce angular SXA PartialDesignDynamicPlaceholder component

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team August 22, 2024 19:20
illiakovalenko
illiakovalenko approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko
Copy link
Contributor

illiakovalenko commented Aug 22, 2024 •
edited
Loading

@sc-addypathania Please update the title to meet the rules that we have: [module] <title>. Set the same title for "merge commit"

@addy-pathania addy-pathania changed the title Introduce angular SXA PartialDesignDynamicPlaceholder component [template/angular-xmcloud] Introduce angular SXA PartialDesignDynamicPlaceholder component Aug 22, 2024
@addy-pathania addy-pathania merged commit e90ab91 into dev Aug 22, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3697-partialDesignDynamicPlaceholder branch August 22, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @illiakovalenko @apathania22