Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-xmcloud-proxy] [Angular] /api/editing/config endpoint #1903

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 22, 2024

Description / Motivation

  • Introduced /api/editing/config endpoint
  • Added CORS, Editing Secret handlers
  • [sitecore-jss-proxy] Updates done to support extensibility to add new properties, modules. Made some restructuring:
    • express@^4.19.2 dependency is marked as a peer dependency, since we reference "express" related types, so it should match
    • Default scProxy middleware export is replaced by headlessProxy object that contains the middleware, ProxyConfig, ServerBundle properties
  • [templates/angular] [templates/angular-xmcloud]:
    • Introduced server.exports.ts file to be able to have different variants per SXP / XMCloud addon's
    • generate-component-factory.ts now writes a list of components as well
    • metadata now can be generated at bootstrap stage
  • Moved EDITING_ALLOWED_ORIGINS, QUERY_PARAM_EDITING_SECRET to sitecore-jss, since now these values are needed for xmcloud proxy middleware

Testing Details

  • Unit Test Added
  • Manual Test/Other Testing using "watch" script

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [XM Cloud Proxy] /api/editing/config endpoint [node-xmcloud-proxy] [Angular] /api/editing/config endpoint Aug 22, 2024
@illiakovalenko illiakovalenko requested a review from a team August 22, 2024 20:36
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears larger than I thought it would be.
Solid job, Illia, thank you. I left some comments, but I leave them to your discretion.

@illiakovalenko illiakovalenko merged commit e8cb657 into dev Aug 26, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-3541 branch August 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants