-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node-xmcloud-proxy] [Angular] /api/editing/config endpoint #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
changed the title
[XM Cloud Proxy] /api/editing/config endpoint
[node-xmcloud-proxy] [Angular] /api/editing/config endpoint
Aug 22, 2024
art-alexeyenko
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears larger than I thought it would be.
Solid job, Illia, thank you. I left some comments, but I leave them to your discretion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
[sitecore-jss-proxy]
Updates done to support extensibility to add new properties, modules. Made some restructuring:express@^4.19.2
dependency is marked as a peer dependency, since we reference "express" related types, so it should matchscProxy
middleware export is replaced byheadlessProxy
object that contains themiddleware
,ProxyConfig
,ServerBundle
properties[templates/angular]
[templates/angular-xmcloud]
:server.exports.ts
file to be able to have different variants per SXP / XMCloud addon'sgenerate-component-factory.ts
now writes a list of components as wellmetadata
now can be generated atbootstrap
stageEDITING_ALLOWED_ORIGINS
,QUERY_PARAM_EDITING_SECRET
tositecore-jss
, since now these values are needed for xmcloud proxy middlewareTesting Details
Types of changes