Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-xmcloud-proxy] Set default PORT number to 3000 #1925

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[node-xmcloud-proxy] Set default PORT number to 3000 #1925

merged 1 commit into from
Sep 11, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 11, 2024 •
edited
Loading

  • This PR follows the Contribution Guide
  • Changelog updated - Not needed, since it's a minor update
  • Upgrade guide entry added

Description / Motivation

Updated default PORT number to 3000, to be aligned with the rest of "node" based proxies.
It allows us to prevent an additional configuration in XM Cloud

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 11, 2024 07:38
yavorsk
yavorsk approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit a792e20 into dev Sep 11, 2024
1 of 2 checks passed
@illiakovalenko illiakovalenko deleted the feature/JSS-4120 branch September 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @yavorsk