Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-sitecore-jss] Bug fix: Removes requirement for base initializer when adding appName to appNames array in case we are scaffolding a non base app #1931

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Sep 16, 2024

Description / Motivation

Removes requirement for base initializer when adding appName to appNames array in case we are scaffolding a non base app; fixes 'Should create nextjs app with Styleguide using post-initializer template only' development test

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…fixes development test 'Should create nextjs app with Styleguide using post-initializer template only'
@yavorsk yavorsk requested a review from a team September 16, 2024 11:04
@illiakovalenko illiakovalenko merged commit ff54a91 into dev Sep 16, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-3939 branch September 16, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants