Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template/angular] [follow-up] Prevent client-side dictionary API call when SSR data is available #1932

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[template/angular] [follow-up] Prevent client-side dictionary API call when SSR data is available #1932

merged 2 commits into from
Sep 18, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 18, 2024 •
edited
Loading

Description / Motivation

Follow up to: #1930

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 18, 2024 13:20
addy-pathania
addy-pathania approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@addy-pathania addy-pathania merged commit 8cb9651 into dev Sep 18, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/JSS-3851-follow-up branch September 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @addy-pathania