Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular-xmcloud][xmcloud-proxy] Personalization support #1964

Merged
merged 31 commits into from
Nov 7, 2024
Merged

[angular-xmcloud][xmcloud-proxy] Personalization support #1964

merged 31 commits into from
Nov 7, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Nov 6, 2024 •
edited
Loading

Description / Motivation

Adds personalization and A/B testing support into angular-xmcloud setup.
Personalization works through xmcloud-proxy and should allow for personalization support for react and vue in future.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

art-alexeyenko and others added 18 commits October 21, 2024 14:50
@art-alexeyenko
export personalize in angular package
e4d232c
@art-alexeyenko
export debug
d37f9e0
@art-alexeyenko
introduce personalize-helper
c01a560
@art-alexeyenko
server-side personalization WIP
4109e7b
@art-alexeyenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/js…
f7de292 
…s-3529-angular-personalize

# Conflicts:
#	packages/sitecore-jss-angular/src/public_api.ts
@art-alexeyenko
use released version of cloudsdk
631901b
@art-alexeyenko
clientside personalization WIP
05035ad
@art-alexeyenko
export more layout types
c6cd265
@art-alexeyenko
temp comment
e0e47c8
@art-alexeyenko
add personalize plugin
8c32b71
@art-alexeyenko
client navigation personalization works
beb5286
@art-alexeyenko
move personalize helper into sitecore-jss-proxy package. add personal…
c64c9ab 
…ize submodule
@illiakovalenko
Added unit tests
acc48ed
@art-alexeyenko
missing functionality, refactor, fix 'headers already sent' bug
cd05717
@art-alexeyenko
more unit tests
a8bb8b9
@illiakovalenko
added excludeRoute unit test
eb8e41f
@art-alexeyenko
finalize tests and implementation
c40a8cc
@art-alexeyenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/js…
44c107a 
…s-3529-angular-personalize

# Conflicts:
#	packages/sitecore-jss-proxy/package.json
#	yarn.lock
@art-alexeyenko art-alexeyenko changed the title [angular-xmcloud][xmvloud-proxy] Personalization support [angular-xmcloud][xmcloud-proxy] Personalization support Nov 6, 2024
@art-alexeyenko art-alexeyenko requested a review from a team November 6, 2024 05:51
yavorsk
yavorsk approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :)

could not find anything significant, just few minor things - one of which to fix the build - otherwise approve from me!

packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/personalize.ts Show resolved Hide resolved
packages/sitecore-jss-angular/src/public_api.ts Show resolved Hide resolved
@yavorsk
Copy link
Contributor

yavorsk commented Nov 6, 2024

One more thing - do we need some migration instructions to the upgrade guide?

illiakovalenko
illiakovalenko requested changes Nov 6, 2024
View reviewed changes
packages/create-sitecore-jss/src/templates/angular-xmcloud/package.json Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/.env Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/config.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/config.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/server.exports.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.ts Outdated Show resolved Hide resolved
@art-alexeyenko
Copy link
Contributor Author

@illiakovalenko @yavorsk Addressed your comments, please take a look.
In regards to upgrade guide, I added some light instructions. Otherwise, there's not much to instruct, right? Xmcloud proxy is a new product, users would simply need to make the switch and start using it.

illiakovalenko
illiakovalenko requested changes Nov 7, 2024
View reviewed changes
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/config.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/config.ts Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/types.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/index.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/personalize/layout-personalizer.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.test.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.test.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.test.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/personalize/PersonalizeHelper.test.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/personalize.d.ts Show resolved Hide resolved
@illiakovalenko
Copy link
Contributor

@art-alexeyenko Can you, please, check code coverage as well? use "npm run coverage", I've seen that code snippets are not covered

illiakovalenko
illiakovalenko approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in advance! Great progress, it looks cleaner now 👍
See one comment below and revert the piece that produces breaking changes personalize/layoutPersonalizer

packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/personalize.ts Outdated Show resolved Hide resolved
@art-alexeyenko art-alexeyenko merged commit 456b9df into dev Nov 7, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-3529-angular-personalize branch November 7, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @yavorsk @illiakovalenko