Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVX2 version of Vp8_Sse4X4 #1860

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Add AVX2 version of Vp8_Sse4X4 #1860

merged 4 commits into from
Nov 30, 2021

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR adds a AVX2 version of Vp8_Sse4X4, which is used during lossy webp encoding.

Related to #1786

Profiler results:

master:

Sse4x4Master

PR

Sse4x4Avx

Test image was Calliphora.png

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1860 (4a9da2f) into master (16ea95b) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1860   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         937     937           
  Lines       48847   48868   +21     
  Branches     6096    6097    +1     
======================================
+ Hits        42622   42647   +25     
+ Misses       5213    5210    -3     
+ Partials     1012    1011    -1     
Flag Coverage Δ
unittests 87% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ImageSharp/Formats/Webp/Lossy/Vp8EncIterator.cs 100% <ø> (ø)
src/ImageSharp/Formats/Webp/Lossy/LossyUtils.cs 100% <100%> (ø)
...mageSharp/Formats/Webp/Lossless/NearLosslessEnc.cs 96% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ea95b...4a9da2f. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brianpopow brianpopow merged commit 3a3059e into master Nov 30, 2021
@brianpopow brianpopow deleted the bp/vp8sse4x4avx branch November 30, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants