Add AVX2 version of CollectHistogram #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1882 +/- ##
======================================
Coverage 87% 87%
======================================
Files 959 959
Lines 50392 50402 +10
Branches 6258 6260 +2
======================================
+ Hits 44113 44122 +9
Misses 5246 5246
- Partials 1033 1034 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gfoidl
reviewed
Dec 9, 2021
| int clippedValue = ClipMax(v, MaxCoeffThresh); | ||
| ++this.distribution[clippedValue]; | ||
| // Load. | ||
| ref short outputRef = ref MemoryMarshal.GetReference<short>(this.output); |
There was a problem hiding this comment.
Suggested change
| ref short outputRef = ref MemoryMarshal.GetReference<short>(this.output); | |
| ref short outputRef = ref MemoryMarshal.GetArrayDataReference(this.output); |
Avoids the intermediate array -> Span step.
But this API is only available from .NET 5 onwards 😢
So maybe just leave the code as is, and remember this API for other uses 😉
There was a problem hiding this comment.
We should definitely start using this once we get rid of supporting the older frameworks
JimBobSquarePants
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds a AVX2 version of CollectHistogram, which is used during lossy webp encoding.
Related to #1786
Profiling results:
master
PR