EXIF IDF pointer #1923
EXIF IDF pointer #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
======================================
Coverage 88% 88%
======================================
Files 966 966
Lines 51353 51350 -3
Branches 6402 6401 -1
======================================
+ Hits 45217 45218 +1
+ Misses 5076 5074 -2
+ Partials 1060 1058 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Can we add a test case based on the #1921 repro steps? |
|
@antonfirsov of course it would be nice to add a test to check 4 zeros at the end |
|
I needs to additional reviewing of EXIF writer methods, it seems there are problems of IFD writing (regarding next IFD pointers and gps sub IFD). Next IFD pointer should be written after each IFD, but at the moment it's written only after the last IFD. |
|
|
||
| int i = 0; | ||
|
|
||
| // The byte order marker for little-endian, followed by the number 42 and a 0 | ||
| ExifConstants.LittleEndianByteOrderMarker.CopyTo(result.AsSpan(start: i)); | ||
| i += ExifConstants.LittleEndianByteOrderMarker.Length; | ||
|
|
||
| uint ifdOffset = ((uint)i - startIndex) + 4U; | ||
| uint thumbnailOffset = ifdOffset + ifdLength + exifLength + gpsLength; |
There was a problem hiding this comment.
in fact, the thumbnail isn't written, this is an unnecessary line
Prerequisites
Description
Fixes for #1921