Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Jpeg Metadata Decoding with unknown APP13 profile #1931

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

mkehoe
Copy link
Contributor

@mkehoe mkehoe commented Jan 9, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fix for Jpeg Decoding Metadata for unknown APP13 profiles. Without this fix the parser will continue parsing any non-Photoshop profile looking for markers and under the right circumstances cause the SOS marker to get missed. Sorry not able to provide the image where this issue was originally encountered for a test case.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2022

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Thanks for your submission @mkehoe we really appreciate it.

Sorry not able to provide the image where this issue was originally encountered for a test case.

I'm assuming this is due to privacy concerns? Is so, no worries. The change is a reasonable optimization without the test image.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1931 (fab1691) into master (576a69f) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1931   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         966     966           
  Lines       51320   51321    +1     
  Branches     6397    6397           
======================================
+ Hits        45188   45189    +1     
  Misses       5074    5074           
  Partials     1058    1058           
Flag Coverage Δ
unittests 88% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 89% <100%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576a69f...fab1691. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants