Use a scheduled job for codecov #1934
Conversation
.github/workflows/code-coverage.yml
Outdated
| jobs: | ||
| Build: | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
Can also be written as:
matrix:
os: ubuntu-latest
runs-on: ${{matrix.os}}
There was a problem hiding this comment.
I’ve just done the minimum amount of changes to make this work. I.E copy/paste/delete
.github/workflows/code-coverage.yml
Outdated
| - cron: '0 2 * * 2,4' | ||
| jobs: | ||
| Build: | ||
| strategy: |
There was a problem hiding this comment.
You are mixing indentation sizes? 2 and 4. According to the .editorconfig this should be 2.
There was a problem hiding this comment.
I wonder why format document didn’t fix this?
There was a problem hiding this comment.
Groan..... Cos format document does seem to exist for yml files in Visual Studio. I'll use VSCode to format both files to 2 spaces.
| - os: ubuntu-latest | ||
| framework: netcoreapp3.1 | ||
| runtime: -x64 | ||
| codecov: true |
There was a problem hiding this comment.
we also loose the netcoreapp3.1 PR tests with this change, is that intentional?
I would have thought we we just want to set codecov: false instead of removing the whole target?
There was a problem hiding this comment.
Whoops! You’re right; will fix
|
I've fixed up all the spotted issues so am gonna merge this. I've got a few backlogged PR's open I want to get merged in without it taking all day. |
Prerequisites
Description
Speed up our CI times by moving code coverage checks to a scheduled workflow. Tue,Thur at 2AM
Note: I've done the bare minimum required to enable this. I didn't want to edit
*.ps1files.https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows