Convert OrientationMode into something usable. #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| } | ||
| else | ||
| { | ||
| orientation = (OrientationMode)Convert.ToUInt16(value.Value); | ||
| orientation = Convert.ToUInt16(value.Value); | ||
| source.Metadata.ExifProfile.RemoveValue(ExifTag.Orientation); |
There was a problem hiding this comment.
This line should be removed, because the value is always set below:
Suggested change
| source.Metadata.ExifProfile.RemoveValue(ExifTag.Orientation); |
There was a problem hiding this comment.
We remove to ensure that any invalid values are gone. We've seen in the wild some odd implementations of this property. SetValue actually calls TrySetValue on the value which can return false.
| source.Metadata.ExifProfile.RemoveValue(ExifTag.Orientation); | ||
| } | ||
|
|
||
| source.Metadata.ExifProfile.SetValue(ExifTag.Orientation, (ushort)OrientationMode.TopLeft); | ||
| source.Metadata.ExifProfile.SetValue(ExifTag.Orientation, ExifOrientationMode.TopLeft); |
There was a problem hiding this comment.
Would you be open to make it possible to opt-in to removing the value, instead of resetting it to ExifOrientationMode.TopLeft? This would require a single bool RemoveExifValue { get; } property and the following code:
if (this.RemoveExifValue)
{
source.Metadata.ExifProfile.RemoveValue(ExifTag.Orientation);
}
else
{
source.Metadata.ExifProfile.SetValue(ExifTag.Orientation, ExifOrientationMode.TopLeft);
}There was a problem hiding this comment.
No, we'll keep it since the value was explicitly set by the previous encoder.
antonfirsov
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I noticed while working on SixLabors/ImageSharp.Web#215 that our
OrientationModeenum was internal. I'm assuming because explicitly casting to aushorteach time was not a great developer experience. By converting it to a static class with constants we're able to expose the type in a much more useful form.