Add tiff and webp to the PackageTags #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemstra
approved these changes
Feb 4, 2022
dlemstra
reviewed
Feb 4, 2022
src/ImageSharp/ImageSharp.csproj
Outdated
| @@ -10,7 +10,7 @@ | |||
| <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> | |||
| <RepositoryUrl Condition="'$(RepositoryUrl)' == ''">https://github.com/SixLabors/ImageSharp/</RepositoryUrl> | |||
| <PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl> | |||
| <PackageTags>Image Resize Crop Gif Jpg Jpeg Bitmap Pbm Png Tga NetCore</PackageTags> | |||
| <PackageTags>Image Resize Crop Gif Jpg Jpeg Bitmap Pbm Png Tga Tiff Webp NetCore</PackageTags> | |||
There was a problem hiding this comment.
Maybe write Webp as WebP instead? Don't think those tags are case sensitive though.
|
It seems the CI does not support netcoreapp2.1/net472 anymore |
|
Yep. I have a fix for that in SixLabors/ImageSharp.Web#217 that we can copy across. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Add tiff and webp to the PackageTags of the project in preparation for release of 2.0